Re: [PATCH net-next v8 02/19] test_bitmap: unit tests for lib/bitmap.c

From: Ben Hutchings
Date: Fri Feb 12 2016 - 20:39:26 EST


On Tue, 2016-02-09 at 16:29 -0800, David Decotigny wrote:
> From: David Decotigny <decot@xxxxxxxxxxxx>
>
> This is mainly testing bitmap construction and conversion to/from u32[]
> for now.
>
> Tested:
> Â qemu i386, x86_64, ppc, ppc64 BE and LE, ARM.
>
> Signed-off-by: David Decotigny <decot@xxxxxxxxxxxx>
[...]
> diff --git a/tools/testing/selftests/lib/bitmap.sh b/tools/testing/selftests/lib/bitmap.sh
> new file mode 100644

This needs to have mode 755.

Ben.

> index 0000000..2da187b
> --- /dev/null
> +++ b/tools/testing/selftests/lib/bitmap.sh
> @@ -0,0 +1,10 @@
> +#!/bin/sh
> +# Runs bitmap infrastructure tests using test_bitmap kernel module
> +
> +if /sbin/modprobe -q test_bitmap; then
> + /sbin/modprobe -q -r test_bitmap
> + echo "bitmap: ok"
> +else
> + echo "bitmap: [FAIL]"
> + exit 1
> +fi
--
Ben Hutchings
Sturgeon's Law: Ninety percent of everything is crap.

Attachment: signature.asc
Description: This is a digitally signed message part