Re: [PART1 RFC 6/9] svm: Add interrupt injection via AVIC

From: Paolo Bonzini
Date: Fri Feb 12 2016 - 13:57:08 EST




On 12/02/2016 19:30, Borislav Petkov wrote:
> On Fri, Feb 12, 2016 at 07:21:17PM +0100, Paolo Bonzini wrote:
>> Hmm, currently things such as MSR_VM_HSAVE_PA are defined in msr-index.h.
>
> But that one is used in 3 files AFAICT.

Ok, next examples: MSR_VM_CR and MSR_VM_IGNNE. :)

>> It's okay for me to move them to kvm_host.h or similar, but they should
>> all be treated the same. Right now this means adding the doorbell MSR
>> to msr-index.h.
>
> Only if it is used in multiple files. The doorbell thing is used once in
> svm.c.
>
> We don't want to make msr-index.h an encyclopedia of any MSR ever
> defined :-)

Are you okay with moving all the SVM MSRs to virtext.h instead?

Thanks,

Paolo