Re: [PATCH v5 00/10] Input: synaptics-rmi4: Synaptics RMI4 Driver

From: Andrew Duggan
Date: Fri Feb 12 2016 - 13:10:29 EST


On 02/12/2016 04:54 AM, Linus Walleij wrote:
On Wed, Feb 10, 2016 at 11:23 PM, Andrew Duggan <aduggan@xxxxxxxxxxxxx> wrote:

This is the v5 patch series which fixes the issues identified by kbuild
and coccinelle in the previous patch series. These include:

- Using ARRAY_SIZE instead of a custom macro to calculate the size of the
function handler array.
- Remove setting the .owner field for the driver in rmi_i2c and rmi_spi
since the i2c-core and spi set that field.
- Fix if statment in rmi_f30 which was testing has_led twice instead of
testing has_gpio.
Works like a charm.
Tested-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks for testing. At this point except for the touchscreen binding rename fix needed in patch 5, all of the outstanding issues have been addressed. If the rest of the patch series is acceptable, then I can do a final v6 respin which fixes the binding and also removes the HID patch. But, if more work needs to be done on the patch series I can wait to do the respin. Dmitry, what do you think of the patch series at this point?

Thanks,
Andrew

Yours,
Linus Walleij