Re: [PATCH v2 3/7] ibmvscsi: Replace magic values in set_adpater_info() with defines

From: James Bottomley
Date: Fri Feb 12 2016 - 11:43:21 EST


On Wed, 2016-02-10 at 19:32 -0600, Tyrel Datwyler wrote:
> Add defines for mad version and mad os_type, and replace the magic
> numbers in set_adapter_info() accordingly.
>
> Signed-off-by: Tyrel Datwyler <tyreld@xxxxxxxxxxxxxxxxxx>
> ---

Is there some reason you didn't carry the review tag over from this:

http://mid.gmane.org/20160204084459.GW27969@xxxxxxxxxxxxxxxxx

?

James