Re: [PATCH V2] regulator: max8973: add support for junction thermal warning

From: Rob Herring
Date: Fri Feb 12 2016 - 09:04:47 EST


On Fri, Feb 12, 2016 at 7:31 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx> wrote:
>
> On Friday 12 February 2016 07:06 PM, Rob Herring wrote:
>>
>> On Wed, Jan 6, 2016 at 10:07 AM, Laxman Dewangan <ldewangan@xxxxxxxxxx>
>> wrote:
>>
>> Enhanced transient response (ETR) will affect the configuration of
>> CKADV.
>> +-maxim,junction-temp-warning: Junction temp warning on which device
>> generates
>> + warning interrupts. This is in millicelcius.
>> Please append units: maxim,junction-temp-warning-millicelsius or
>> perhaps maxim,junction-warn-millicelsius to shorten it a bit.
>
> This is very generic which is there on most of PMIC devices from Maxim, TI
> etc.
> So can we make it generic i.e. do not prefix with vendor name like
> "junction-warn-millicelsius"?

I've got no problem with that.

Rob