Re: [PATCH V4 3/7] cpufreq: Remove cpufreq_governor_lock

From: Rafael J. Wysocki
Date: Thu Feb 11 2016 - 04:53:52 EST


On Tue, Feb 9, 2016 at 4:46 AM, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> We used to drop policy->rwsem just before calling __cpufreq_governor()
> in some cases earlier and so it was possible that __cpufreq_governor()
> runs concurrently via separate threads.
>
> In order to guarantee valid state transitions for governors,
> 'governor_enabled' was required to be protected using some locking and
> we created cpufreq_governor_lock for that.
>
> But now, __cpufreq_governor() is always called from within policy->rwsem
> held and so 'governor_enabled' is protected against races even without
> cpufreq_governor_lock.
>
> Get rid of the extra lock now.

This one looks good, but depends on the [2/7].

Thanks,
Rafael