Re: [RFC][PATCH v3 1/4] printk: move can_use_console out of console_trylock_for_printk

From: Sergey Senozhatsky
Date: Thu Feb 11 2016 - 03:00:03 EST


Hello Petr,

On (02/10/16 17:48), Petr Mladek wrote:
[..]
> I would personally remove console_trylock_for_printk() already in this
> patch. I mean to fold the 3rd patch into this one.

will do.

> > int printk_delay_msec __read_mostly;
>
> > @@ -2247,9 +2233,21 @@ void console_unlock(void)
> > do_cond_resched = console_may_schedule;
> > console_may_schedule = 0;
> >
> > +again:
> > + /*
> > + * We released the console_sem lock, so we need to recheck if
> > + * cpu is online and (if not) is there at least one CON_ANYTIME
> > + * console.
> > + */
> > + if (!can_use_console()) {
> > + console_locked = 0;
> > + up_console_sem();
> > + return;
> > + }
>
> This is a bug fix and a nice clean up together.
>
> Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

thanks.

-ss