Re: [PATCH v8] SATA: OCTEON: support SATA on OCTEON platform

From: Tejun Heo
Date: Wed Feb 10 2016 - 13:16:57 EST


On Wed, Feb 10, 2016 at 10:12:52AM -0800, David Daney wrote:
> On 02/10/2016 08:02 AM, Tejun Heo wrote:
> >On Tue, Feb 09, 2016 at 12:04:29PM +0000, Zubair Lutfullah Kakakhel wrote:
> >...
> >> .../devicetree/bindings/ata/ahci-platform.txt | 1 +
> >> .../devicetree/bindings/mips/cavium/sata-uctl.txt | 42 +++++++++
> >> arch/mips/include/asm/octeon/cvmx.h | 9 ++
> >> drivers/ata/Kconfig | 9 ++
> >> drivers/ata/Makefile | 1 +
> >> drivers/ata/ahci_platform.c | 1 +
> >> drivers/ata/sata_octeon.c | 105 +++++++++++++++++++++
> >
> >Don't we usually name these ahci variants ahci_xxx?
> >
>
> Just to be clear, are you suggesting renaming sata_octeon.c to
> ahci_octeon.c?

Yeah, unless there are reasons not to.

Thanks.

--
tejun