Re: [PATCH 8/9] rfkill: Userspace control for airplane mode

From: Johannes Berg
Date: Wed Feb 10 2016 - 12:12:53 EST


On 2016-02-10 17:53, Dan Williams wrote:
Yeah, I get that now. ÂIt's just that to me, something called
"AIRPLANE_MODE_CHANGE" seems like it should actually change airplane
mode on/off, which implies killing radios. ÂI wouldn't have had the
problem if it was named AIRPLANE_MODE_INDICATOR_CHANGE, which makes it
clear this is simply an indicator and has no actual effect on anything
other than a LED.

Yeah, I agree. I'm not even sure that it's a good idea to subsume this into the regular operations in the API, although that's obviously the easiest extension. I'll need to think about that a bit more with the code at hand though.

johannes