Re: [PATCH 1/8] clk: add device tree binding for artpec-6 pll1 clock

[Arnd Bergmann]

On Wednesday 10 February 2016 13:41:50 Lars Persson wrote:
> Signed-off-by: Lars Persson <larper@xxxxxxxx>
> ---

Always write a changelog comment.

> +* Clock bindings for Axis ARTPEC-6 chip
> +
> +Required properties:
> +- compatible: Should be "axis,artpec6-pll1-clock"
> +- #clock-cells: Should be <1>

What is the clock cell used for?

> +Examples:
> +
> +pll1_clk: pll1_clk {
> +	#clock-cells = <1>;
> +	compatible = "axis,artpec6-pll1-clock";
> +	clocks = <&ext_clk>;
> +	status = "okay";
> +};
>