Re: [PATCH] clk: clk_register: Correctly initialize enable_count

From: Emilio LÃpez
Date: Tue Feb 09 2016 - 22:10:55 EST


Hi,

El 09/02/16 a las 19:48, Rhyland Klein escribió:
> When clocks are registered, they could be enabled already in
> hardware. As of now, the enable count will start at 0. When this
> happens, it means a clock is enabled and the framework doesn't know
> that, so it will always report it as disabled.

Keep in mind that during the boot process, towards the end, unused
clocks get disabled, so the state remains in sync. If suddenly the
enable_count on unused clocks is not 0, this will break and unused
clocks will remain on, wasting power.

http://lxr.free-electrons.com/source/drivers/clk/clk.c#L244

What issue were you having that prompted you to write this patch?

Cheers,
Emilio