Re: [PATCH V7 1/8] mfd: add device-tree binding doc for PMIC max77620/max20024

[Laxman Dewangan]

On Tuesday 09 February 2016 09:12 PM, Lee Jones wrote:
> On Sat, 30 Jan 2016, Laxman Dewangan wrote:
>
> +	Normal mode also called as active mode on which all step-down
> +		regulators, all linear regulators, GPIOs, and the 32kHz
> +		oscillator are in normal active mode.
> +	sleep mode: Regulators/GPIOs/clock can go on OFF state based on
> "can go on OFF state"?

Regulator/GPIO has two states, enable and disable. If sleep mode is 
configured for these resource and external signal triggers to sleep then 
this get disabled.
> > +	Different modes of regulators/clock/GPIOs are controlled by the their
> > +FPS configurations. There is different configuration registers for each of
> > +these resources. Typical configurations per resource are:
> > +	FPS source: 	Attach the resource to required FPS source. When
> > +			resources are attached to one of FPS source then
> > +			resournce can be enable/disable when related FPS
> Have you used spell check?  I suggest you do.

My bad, I did but mixed with technical ignorance. Will try best.

> > +			source gets the control signal for ON and OFF.
> > +	Power on slot: 	Slot number on which resource is ON once FPS source
> > +			get ON signal.
> Can you find another way of explaining this please?

Hmm..
Does it look fine:
There is 8 slots for each FPS on which resource can get enabled. This 
property provides the slot number on which resource gets enabled after 
FPS sequence started.


> +
> +-maxim,enable-sleep: 		    Boolean, enable sleep state of PMIC
> We already have bindings for sleeping.  Please use a generic one.

Which property? Saw sleep property with vendor prefix.