[tip:x86/microcode] x86/microcode: Remove an unneeded NULL check

From: tip-bot for Dan Carpenter
Date: Tue Feb 09 2016 - 07:22:37 EST


Commit-ID: 43858f57bc02388a6420321c021397591199cf91
Gitweb: http://git.kernel.org/tip/43858f57bc02388a6420321c021397591199cf91
Author: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
AuthorDate: Wed, 3 Feb 2016 12:33:32 +0100
Committer: Ingo Molnar <mingo@xxxxxxxxxx>
CommitDate: Tue, 9 Feb 2016 11:41:16 +0100

x86/microcode: Remove an unneeded NULL check

"uci" is an element of the ucode_cpu_info[] array, it can't be NULL.

Tested-by: Thomas Voegtle <tv@xxxxxxxx>
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Signed-off-by: Borislav Petkov <bp@xxxxxxx>
Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Cc: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
Cc: kernel-janitors@xxxxxxxxxxxxxxx
Link: http://lkml.kernel.org/r/1454499225-21544-5-git-send-email-bp@xxxxxxxxx
Link: http://lkml.kernel.org/r/20140120103046.GC14233@xxxxxxxxxxxxxx
Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
---
arch/x86/kernel/cpu/microcode/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/microcode/core.c b/arch/x86/kernel/cpu/microcode/core.c
index bca4e48..cea8552 100644
--- a/arch/x86/kernel/cpu/microcode/core.c
+++ b/arch/x86/kernel/cpu/microcode/core.c
@@ -472,7 +472,7 @@ static enum ucode_state microcode_init_cpu(int cpu, bool refresh_fw)
enum ucode_state ustate;
struct ucode_cpu_info *uci = ucode_cpu_info + cpu;

- if (uci && uci->valid)
+ if (uci->valid)
return UCODE_OK;

if (collect_cpu_info(cpu))