Re: [PATCH 5/5] asus-wmi: Add quirk_no_rfkill for the Asus Z550MA

From: Darren Hart
Date: Mon Feb 08 2016 - 16:03:54 EST


On Mon, Feb 08, 2016 at 12:05:23PM -0500, João Paulo Rechi Vita wrote:

I'm waiting for the RFKILL reviews to complete, but quickly, patches 4 and 5
require a commit message. There is always something you can add here, for
example, do these not have a switch or is it handled by a different driver? Etc.

> Signed-off-by: João Paulo Rechi Vita <jprvita@xxxxxxxxxxxx>
> Reported-by: Ming Shuo Chiu <chiu@xxxxxxxxxxxx>
> ---
> drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index 4ded187..5adb842 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -328,6 +328,15 @@ static const struct dmi_system_id asus_quirks[] = {
> },
> .driver_data = &quirk_no_rfkill,
> },
> + {
> + .callback = dmi_matched,
> + .ident = "ASUSTeK COMPUTER INC. Z550MA",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Z550MA"),
> + },
> + .driver_data = &quirk_no_rfkill,
> + },
> {},
> };
>
> --
> 2.5.0
>
>

--
Darren Hart
Intel Open Source Technology Center