Re: [PATCH] x86/setup: refactor initrd reservation

From: Andy Shevchenko
Date: Mon Feb 08 2016 - 10:56:51 EST


On Fri, Feb 5, 2016 at 7:38 PM, Alexander Kuleshov
<kuleshovmail@xxxxxxxxx> wrote:
> The check and definitions related to ramdisk are similar in the
> early_reserve_initrd() and reserve_initrd(). So we can get rid of
> early_reserve_initrd() and and use late or early algorithm for
> initrd reservation depends on reserve_initrd() parameter value.

Perhaps: "Squash {early_,}reserve_initrd() to one function" would be
better for Subject line since it describes what you are doing here
(Answering question "What kind of refactor?").

Also if you have more argument (like .text size before and after) I
suppose it would have been passed faster.

> +static void __init reserve_initrd(int early)

Why int and not bool?

--
With Best Regards,
Andy Shevchenko