Re: [PATCH 2/3] arm64: dts: add the Alpine v2 EVP

From: Mark Rutland
Date: Mon Feb 08 2016 - 05:51:55 EST


Hi,

> + chosen {
> + stdout-path = "console0:115200n8";
> + };

There is no console0 alias, so this cannot work.

Did you mean serial0?

[...]

> + aliases {
> + serial0 = &uart0;
> + serial1 = &uart1;
> + serial2 = &uart2;
> + serial3 = &uart3;
> + };

[...]

> + psci {
> + compatible = "arm,psci-0.2", "arm,psci";
> + method = "smc";
> + cpu_on = <0x84000003>;
> + };

If you have PSCI 0.2, the cpu_on ID (and all other mandatory function
IDs) are implicit.

If you want to have "arm,psci" as a fallback, then please add the IDs
for functions mandatory in PSCI 0.2 which existed in the "arm,psci"
binding. Otherwise, drop "arm,psci" from the compatible list, along
with the cpu_on function ID.

THanks,
Mark.