Re: [PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig

From: Chris Wilson
Date: Mon Jan 25 2016 - 06:26:23 EST


On Mon, Jan 25, 2016 at 12:14:41PM +0100, Andreas Ziegler wrote:
> Commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig
> dependency") removed the option STOP_MACHINE from init/Kconfig, but
> missed a select to this option from the DRM_I915 option.

The select didn't exist on the branch on which the patch was applied, so
it couldn't remove it.

Commit 5bab6f60cb4 ("drm/i915: Serialise updates to GGTT with access
through GGTT on Braswel") depended upon a working stop_machine() and so
forced its selection. However, commit 86fffe4a61dd ("kernel: remove
stop_machine() Kconfig dependency") removed the option STOP_MACHINE from
init/Kconfig and ensured that stop_machine() universally works.

Remove this now obsolete select statement.

> Signed-off-by: Andreas Ziegler <andreas.ziegler@xxxxxx>

With a little bit of story correction,
Revieweed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris

--
Chris Wilson, Intel Open Source Technology Centre