[PATCH v2 07/16] dell-smbios: don't return an SMBIOS buffer from dell_smbios_send_request()

From: MichaÅ KÄpieÅ
Date: Fri Jan 22 2016 - 09:29:55 EST


An SMBIOS buffer pointer does not need to be returned by
dell_smbios_send_request(), because SMBIOS call results are stored in
the buffer passed as input.

Signed-off-by: MichaÅ KÄpieÅ <kernel@xxxxxxxxxx>
---
drivers/platform/x86/dell-smbios.c | 5 +----
drivers/platform/x86/dell-smbios.h | 3 +--
2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
index d573765..b10c613 100644
--- a/drivers/platform/x86/dell-smbios.c
+++ b/drivers/platform/x86/dell-smbios.c
@@ -59,8 +59,7 @@ void dell_smbios_release_buffer(void)
}
EXPORT_SYMBOL_GPL(dell_smbios_release_buffer);

-struct calling_interface_buffer *
-dell_smbios_send_request(int class, int select)
+void dell_smbios_send_request(int class, int select)
{
struct smi_cmd command;

@@ -74,8 +73,6 @@ dell_smbios_send_request(int class, int select)
buffer->select = select;

dcdbas_smi_request(&command);
-
- return buffer;
}
EXPORT_SYMBOL_GPL(dell_smbios_send_request);

diff --git a/drivers/platform/x86/dell-smbios.h b/drivers/platform/x86/dell-smbios.h
index 4220ac1..80b5048 100644
--- a/drivers/platform/x86/dell-smbios.h
+++ b/drivers/platform/x86/dell-smbios.h
@@ -41,8 +41,7 @@ extern struct calling_interface_token *da_tokens;
void dell_smbios_get_buffer(void);
void dell_smbios_clear_buffer(void);
void dell_smbios_release_buffer(void);
-struct calling_interface_buffer *
-dell_smbios_send_request(int class, int select);
+void dell_smbios_send_request(int class, int select);

int find_token_id(int tokenid);
int find_token_location(int tokenid);
--
1.7.10.4