Re: [PATCH v2 02/10] rtc: max77686: Use ARRAY_SIZE() instead of current array length

[Javier Martinez Canillas]

Hello Laxman,

Thanks a lot for your feedback and acks.

On 01/22/2016 06:39 AM, Laxman Dewangan wrote:
> On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote:
> > It is better to use the ARRAY_SIZE() macro instead of the array length
> > to avoid bugs if the array is later changed and the length not updated.
> >
> > Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
> > Reviewed-by: Krzysztof Kozlowski <k.kozlowski@xxxxxxxxxxx>
> Acked-by: Laxman Dewangan <ldewangan@xxxxxxxxxx>
>
>
> Similar stuffs are there on multiple places:
> u8 data[RTC_NR_TIME];
>
> :::
> ret = regmap_bulk_read(info->max77686->rtc_regmap,
>                                   MAX77686_ALARM1_SEC, data, RTC_NR_TIME);
>
>
> Should we say:
> ret = regmap_bulk_read(info->max77686->rtc_regmap,
>                                   MAX77686_ALARM1_SEC, data, ARRAY_SIZE(data));

Very good point, I'll change those on this patch as well for v3.

Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America