Re: [PATCH v3 20/21] efi: stub: use high allocation for converted command line

From: Matt Fleming
Date: Thu Jan 21 2016 - 11:21:07 EST


On Mon, 11 Jan, at 02:19:14PM, Ard Biesheuvel wrote:
> Before we can move the command line processing before the allocation
> of the kernel, which is required for detecting the 'nokaslr' option
> which controls that allocation, move the converted command line higher
> up in memory, to prevent it from interfering with the kernel itself.
>
> Since x86 needs the address to fit in 32 bits, use UINT_MAX as the upper
> bound there. Otherwise, use ULONG_MAX (i.e., no limit)
>
> Cc: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx>
> ---
> arch/x86/include/asm/efi.h | 2 ++
> drivers/firmware/efi/libstub/efi-stub-helper.c | 14 +++++++++++++-
> 2 files changed, 15 insertions(+), 1 deletion(-)

Reviewed-by: Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx>