Re: [patch] amd64_edac: shift wrapping issue in f1x_get_norm_dct_addr()

From: Aravind Gopalakrishnan
Date: Thu Jan 21 2016 - 10:30:13 EST


On 1/21/2016 6:32 AM, Borislav Petkov wrote:
On Wed, Jan 20, 2016 at 12:54:51PM +0300, Dan Carpenter wrote:
+ u64 dct_sel_base_off = (u64)(pvt->dct_sel_hi & 0xFFFFFC00) << 16;


@Aravind: do you have a box with

setpci -s 18.2 0x114.l

bits [31:16] not 0?




Nope. I don't see it set on my Fam10h and Fam15h Model 00-0fh systems.

But yes, nice catch!

-Aravind.