Re: [PATCH 01/14] dell-laptop: extract SMBIOS-related code to a separate module

From: MichaÅ KÄpieÅ
Date: Thu Jan 21 2016 - 08:39:31 EST


> Another idea:
>
> What about passing struct calling_interface_buffer from caller allocated
> memory (either from stack or kernel alloc) to dell-smbios which will
> copy it into own buffer under 4GB and then pass it to dcdbas?
>
> This will avoid to use that get/release function and there will be only
> one send_request.

Well, yes, these two functions could then be ripped out, but the callers
would have to do the error checking on their own. Of course that's not
a bad thing per se, but it changes the currently used concept.

> But I will let decision for API to other people as I do not know what
> the best API to use here...

In order to avoid delaying this any further, I'll post a v2 soon and
hopefully it'll be good enough for your Acked-by. If it turns out more
people have misgivings about it, I'll adjust the code.

--
Best regards,
MichaÅ KÄpieÅ