Re: [PATCH v2 00/11] lib/vsprintf: refactor and introduce %pl specifier

From: Andy Shevchenko
Date: Thu Jan 21 2016 - 07:50:54 EST


On Fri, 2016-01-15 at 00:23 +0200, Andy Shevchenko wrote:
> This series refactors vsprintf.c, introduces %pl specifier to print
> unsigned
> long long value in human-readable format, enhances EFI messages, and
> converts
> existing users of such functionality.
>
> The series has been tested on 32-bit and 64-bit Intel platforms with
> test_printf.c suite.
>
> In the future someone can extend %pl to cover the cases like
> string_get_size()
> does.

Rasmus, thanks for review.

Andrew, please don't take this series anyhow, I'm also pretty sure
there will be no v3 of it anyway.

>
> Andy Shevchenko (10):
> Â lib/vsprintf: introduce put_one_char() for 3 line idiom
> Â lib/vsprintf: make default_dec_spec global
> Â lib/vsprintf: make default_str_spec global
> Â lib/string_helpers: export string_units_{2,10} for others
> Â lib/string_helpers: fix indentation in few places
> Â lib/vsprintf: introduce %pl to print in human-readable form
> Â lib/vsprintf: allow range of prefix for %pl[From[To]]
> Â lib/vsprintf: use precision field with %pl[From[To]]
> Â cxgb4: print value in human-readable form via %.0plKM
> Â pcmciamtd: print value in human-readable form via %.0plKM
>
> Robert Elliott (1):
> Â x86/efi: print size and base in binary units in efi_print_memmap
>
> ÂDocumentation/printk-formats.txtÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ22 ++
> Âarch/x86/platform/efi/efi.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ11 +-
> Âdrivers/mtd/maps/pcmciamtd.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ12 +-
> Âdrivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c |ÂÂ11 +-
> Âinclude/linux/string_helpers.hÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂÂ6 +
> Âlib/string_helpers.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ26 +-
> Âlib/test_printf.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ84 +++++-
> Âlib/vsprintf.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 296 ++++++++++-
> ----------
> Â8 files changed, 277 insertions(+), 191 deletions(-)
>

--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy