Re: [PATCH] PM / devfreq: tegra: Set freq in rate callback

From: MyungJoo Ham
Date: Thu Jan 21 2016 - 04:24:23 EST


>As per the documentation of the devfreq_dev_profile.target callback, set
>the freq argument to the new frequency before returning.
>
>This caused endless messages like this after recent changes in the core:
>
>devfreq 6000c800.actmon: Couldn't update frequency transition information.
>
>Signed-off-by: Tomeu Vizoso
>Reported-by: Tyler Baker

Ah.. this is critical and material for LTS queue.

Signed-off-by: MyungJoo Ham <myungjoo.ham@xxxxxxxxxxx>

>---
> drivers/devfreq/tegra-devfreq.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/devfreq/tegra-devfreq.c b/drivers/devfreq/tegra-devfreq.c
>index 848b93ee930f..fe9dce0245bf 100644
>--- a/drivers/devfreq/tegra-devfreq.c
>+++ b/drivers/devfreq/tegra-devfreq.c
>@@ -500,6 +500,8 @@ static int tegra_devfreq_target(struct device *dev, unsigned long *freq,
> clk_set_min_rate(tegra->emc_clock, rate);
> clk_set_rate(tegra->emc_clock, 0);
>
>+ *freq = rate;
>+
> return 0;
> }
>
>--
>2.5.0
>