Re: [PATCH v3 2/4] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts

[Yang Zhang]

On 2016/1/21 14:02, Wu, Feng wrote:
> > -----Original Message-----
> > From: Yang Zhang [mailto:yang.zhang.wz@xxxxxxxxx]
> > Sent: Thursday, January 21, 2016 1:58 PM
> > To: Wu, Feng <feng.wu@xxxxxxxxx>; pbonzini@xxxxxxxxxx;
> > rkrcmar@xxxxxxxxxx
> > Cc: linux-kernel@xxxxxxxxxxxxxxx; kvm@xxxxxxxxxxxxxxx
> > Subject: Re: [PATCH v3 2/4] KVM: x86: Use vector-hashing to deliver lowest-
> > priority interrupts
> >
> > > > I remember we have discussed that even the LAPIC is software disabled,
> > > > it still can respond to some interrupts like INIT, NMI, SMI, and SIPI
> > > > messages. Isn't current logic still problematically?
> > >
> > > I don't think there are problems, here we only cover lowest-priority mode.
> >
> > Does Intel SDM said those interrupts cannot be delivered on
> > lowest-priority mode?
>
> Fixed, Lowest-priority, SMI, NMI, INIT are all "Delivery Mode", once it is
> Lowest-priority, it cannot be other type, afaik.

You are correct, I missed it with physical and logical mode. Also, i 
noticed you have the check at the beginning:

+		if (!kvm_lowest_prio_delivery(irq))
+			goto set_irq;

--
best regards
yang