RE: [PATCH v5 4/4] platform:x86: Add Intel Telemetry Debugfs interfaces

From: Chakravarty, Souvik K
Date: Wed Jan 20 2016 - 21:51:00 EST




> -----Original Message-----
> From: Darren Hart [mailto:dvhart@xxxxxxxxxxxxx]
> Sent: Thursday, January 21, 2016 5:05 AM
> To: Joe Perches <joe@xxxxxxxxxxx>
> Cc: Chakravarty, Souvik K <souvik.k.chakravarty@xxxxxxxxx>; platform-
> driver-x86@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 4/4] platform:x86: Add Intel Telemetry Debugfs
> interfaces
>
> On Tue, Jan 19, 2016 at 11:00:46PM -0800, Joe Perches wrote:
> > On Wed, 2016-01-20 at 11:34 +0530, Souvik Kumar Chakravarty wrote:
> > > This implements debugfs interfaces for reading the telemetry samples
> > > from SSRAM and configuring firmware trace verbosity.
> > []
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > []
> > > @@ -5698,6 +5698,7 @@ S: Maintained
> > >  F: drivers/platform/x86/intel_telemetry_core.c
> > >  F: arch/x86/include/asm/intel_telemetry.h
> > >  F: drivers/platform/x86/intel_telemetry_pltdrv.c
> > > +F: drivers/platform/x86/intel_telemetry_debugfs.c
> >
> > Maybe most of these should be deleted and this should be a single
> > entry:
> >
> > F: drivers/platform/x86/intel_telemetry*
>
> Indeed, thanks for catching that Joe.

Seems fair. I can do a respin.
>
> --
> Darren Hart
> Intel Open Source Technology Center