Re: [PATCH v4 0/4] Cleaning printk stuff in NMI context

From: Andrew Morton
Date: Wed Jan 20 2016 - 16:17:21 EST


On Fri, 11 Dec 2015 14:20:48 +0100 Petr Mladek <pmladek@xxxxxxxx> wrote:

> this is just a quick respin of the previous version. It changes
> the few details as you suggested. Also it fixes the build problem
> on ARM as reported by Geert and Arnd.
>
> I rather send the whole patch set because there is the renamed header.
> Also the extra blank space affects two patches. I hope that it will
> safe you some work. Please, let me know if you would prefer
> incremental patches.
>
>
> Changes against v3:
>
> + used size_t for "len" and "size"
>
> + replaced WARN() with pr_err()
>
> + renamed kernel/printk/printk.h -> internal.h
>
> + fixed build on ARM (undefined NMI_LOG_BUF_SHIFT)

So the review of the v3 patchset was ... inconclusive. And everyone has
gone quiet about v4.

Probably because you didn't cc the V3 discussion participants when
sending out V4. Big mistake, sorry, I can't check everything!

But v4 is basically unaltered from v3 so can we please rev this up
again? yay or nay? Thanks.