Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

[Andy Shevchenko]

On Wed, Jan 20, 2016 at 9:46 PM, MÃns RullgÃrd <mans@xxxxxxxxx> wrote:

>>>> One comment still regarding to lli types. We can avoid warnings by
>>>> using (__force u32) in macros.
>>>
>>> But that won't give the benefits of having the types checked.
>>
>> You mean if we access the lli->field directly? I didn't quite get what
>> use case you are keeping in mind.
>
> Yes, accessing any of those fields directly with my patch gives a sparse
> warning.  It's situations like these those checks are intended for.
> Defeating them seems foolish to me.

Otherwise it makes that struct looks ugly.
Why not union, though it still ugly, but less.

-- 
With Best Regards,
Andy Shevchenko