Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

From: Andy Shevchenko
Date: Wed Jan 20 2016 - 14:38:33 EST


On Wed, Jan 20, 2016 at 9:24 PM, MÃns RullgÃrd <mans@xxxxxxxxx> wrote:
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
>
>> On Wed, 2016-01-20 at 18:50 +0000, MÃns RullgÃrd wrote:
>>> Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> writes:
>>>
>>> > > Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver).
>>> > >
>>> > > Code here:
>>> > > https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata
>>> >
>>> > Thanks for testing!
>>>
>>> Have you had time to look any more at these patches?
>>
>> Not yet.
>> I will look soon for sure.
>>
>> One comment still regarding to lli types. We can avoid warnings by
>> using (__force u32) in macros.
>
> But that won't give the benefits of having the types checked.

You mean if we access the lli->field directly? I didn't quite get what
use case you are keeping in mind.

--
With Best Regards,
Andy Shevchenko