Re: [PATCH v6 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core

From: chenfeng
Date: Tue Jan 19 2016 - 22:52:18 EST




On 2016/1/20 1:30, Mark Brown wrote:
> On Tue, Jan 19, 2016 at 02:31:59PM +0800, Chen Feng wrote:
>
>> Chen Feng (5):
>> doc: bindings: Add document for mfd hi665x PMIC
>> doc: bindings: Document for hi655x regulator driver
>> mfd: hi655x: Add hi665x pmic driver
>> regulator: add regulator driver of hi655x pmic
>> hisilicon/dts: Add hi655x pmic dts node
>
> I've asked you several times to use subject lines reflecting the style
> for the subsystem for the DT bindings (and have just noticed that the
> same thing applies to the DTS update).
>
Mark,

Really sorry for this.
Since I have not caught what you mean before this time.

I changed the style problem from doc:bindings to doc: bindings.
A blank space added. But this was not accurately what you mean.

I will change it like this:
bindings: mfd: hi655x: Add document for mfd hi665x PMIC
bindings: regulator: hi655x: Document for hi655x regulator driver
regulator: hi655x: add regulator driver of hi655x pmic
arm64: dts: hisilicon: Add hi655x pmic dts node

Will this be okay?

Have you also reviewed the regulator driver code? I changed it to
of_match and regulators_node without opening code.

Thanks again for your advice.

Feng