RE: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts

From: Wu, Feng
Date: Mon Jan 18 2016 - 23:44:42 EST




> -----Original Message-----
> From: Paolo Bonzini [mailto:pbonzini@xxxxxxxxxx]
> Sent: Monday, January 18, 2016 6:42 PM
> To: Wu, Feng <feng.wu@xxxxxxxxx>; Radim Krcmár <rkrcmar@xxxxxxxxxx>
> Cc: kvm@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest-
> priority interrupts
>
>
>
> On 18/01/2016 06:19, Wu, Feng wrote:
> > However,
> > this will make the vector-hashing lowest-priority handling slightly different
> > compare to round-robin, since RR checks "!dst[i]" before injecting the
> > interrupts. What is your opinion about it? Thanks a lot!
>
> I think Radim's suggestion is fine. You can print an error (just once
> per guest) to dmesg if the result of the hashing computation corresponds
> to a disabled APIC.

Good idea, is there already a convenient way to do this in KVM?

Thanks,
Feng

>
> Paolo