Re: [PATCH v4] serial: 8250: add gpio support to exar

From: Sudip Mukherjee
Date: Mon Jan 18 2016 - 09:07:03 EST


On Mon, Jan 18, 2016 at 03:39:01PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 18, 2016 at 2:10 PM, Sudip Mukherjee
> <sudipm.mukherjee@xxxxxxxxx> wrote:
> > Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
> > can be controlled using gpio interface.
> > Add support to use these pins.
>
> Looks better, butâ
>
> > drivers/gpio/Kconfig | 7 ++
> > drivers/gpio/Makefile | 1 +
>
> Why is it here?
>
> > drivers/tty/serial/8250/8250_gpio.c | 243 ++++++++++++++++++++++++++++++++++++

OOPS... I am sorry, I have made a complete mess of this patch. :(
This was supposed to have drivers/gpio/gpio-exar.c and
not drivers/tty/serial/8250/8250_gpio.c
The entire gpio related code was moved to drivers/gpio/gpio-exar.c and
8250_pci.c was only adding the platform device.
I will post the correct patch tomorrow.
Sorry again.

regards
sudip