Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB

From: Elad Raz
Date: Wed Jan 13 2016 - 12:04:16 EST



> On Jan 13, 2016, at 2:28 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
>
> There is a missing break statement so we always return -EOPNOTSUPP.
>
> Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Acked-by: Elad Raz <eladr@xxxxxxxxxxxx>

>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> index ffe894e..45479ef 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> @@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
> case SWITCHDEV_OBJ_ID_PORT_MDB:
> err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
> SWITCHDEV_OBJ_PORT_MDB(obj));
> + break;
> default:
> err = -EOPNOTSUPP;
> break;