Re: [PATCH V2 6/6] regulator: max77620: add regulator driver for max77620/max20024

[Laxman Dewangan]

On Wednesday 13 January 2016 05:27 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Wed, Jan 13, 2016 at 05:09:55PM +0530, Laxman Dewangan wrote:
>
> > Yaah, this is something new and I think Mark also wanted to do this cleanup
> > on his comment. I did not understand it previously. Looks cool now.
> I did, please don't just ignore review comments.
Sure, I respect all comments and thanks for review.
Seems your mail got lost somewhere (still not seeing in my inbox).

> > However, I have requirement to configure PMIC with some inital setting based
> > on init_data (parsed) before regulator registration happened. Once I move to
> > this new mecahinsm, the inti_data parsing and regulator init happen in the
> > same function. So I need to have one callback from regulator_register to
> > driver.
> > Something below. This will do the pre configuration before
> > regulator_register happena dn machine constraint sets.
> > I can not use the init_data->regulator_init() as I need to have the init
> > data passed to the driver.
> Why do you have this requirement?

This is require to
- configure FPS_SRC based on platform data for each rail,
    - If FPS_SRC enabled then enable it always.
    - If FPS_SRC is disabled (NONE) then based on init data constraint,
      set it to desired state.
- Power mode and slew rate init based on default configuration from the 
register if platform does not want to set it.