Re: [PATCH -next] gpio: mm-lantiq: Do not use gpiochip_get_data() in ltq_mm_save_regs()

[Linus Walleij]

On Thu, Jan 7, 2016 at 5:24 PM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

> Commit 6aa7dbfa2877 ("gpio: mm-lantiq: use gpiochip data pointer") replaces
> the use of container_of() with gpiochip_get_data(). However, the data
> pointer is not yet set by the time the save_regs function is called.
>
> Fixes: 6aa7dbfa2877 ("gpio: mm-lantiq: use gpiochip data pointer")
> Cc: Ricardo Ribalda Delgado <ricardo.ribalda@xxxxxxxxx>
> Cc: John Crispin <blogic@xxxxxxxxxxx>
> Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Patch applied.

> It might make sense to merge this patch into the patch causing the problem.

Nah, don't wanna rebase. Plus people should see all mistakes I make...

Yours,
Linus Walleij