Re: [PATCH v2 6/7] udf: Remove struct ustr as non-needed intermediate storage

From: Jan Kara
Date: Tue Jan 12 2016 - 08:39:12 EST


Hi Andrew,

On Mon 11-01-16 16:31:40, Andrew Gabbasov wrote:
> > >
> > > - ocu[length - 1] = (uint8_t)u_len + 1;
> > > - return u_len + 1;
> > > + return u_len;
> >
> > It seems you removed setting of the length in the resulting CS0 string.
>
> Yes, and it was done deliberately.
> udf_name_to_CS0 and its caller udf_put_filename functions are used for
> writing File Identifier fields only, which are not "dstrings", that is
> not containing the length in last byte. The last byte with the length
> from these functions would not be copied to filesystem or used in any
> other way.

I see, you are right. OK.

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR