Re: [PATCH] arm: irq: l2c: do not print error in case of missing l2c from dtb

From: Joe Perches
Date: Tue Jan 12 2016 - 02:11:32 EST


On Tue, 2016-01-12 at 15:34 +0900, Andi Shyti wrote:
> In some architectures the L2 cache controller is integrated in the
> processor's block itself and it doesn't use any external cache
> controller. This means that an entry in the board's dtb related
> to the l2c is not necessary.
>
> Distinguish between error codes and print just an information in
> case of -ENODEV.

trivia:

> diff --git a/arch/arm/kernel/irq.c b/arch/arm/kernel/irq.c
[]
> @@ -95,7 +95,9 @@ void __init init_IRQ(void)
>   outer_cache.write_sec = machine_desc->l2c_write_sec;
>   ret = l2x0_of_init(machine_desc->l2c_aux_val,
>      machine_desc->l2c_aux_mask);
> - if (ret)
> + if (ret == -ENODEV)
> + pr_info("no L2C controller entry found in the dtb\n");

Perhaps this would be more consistent if it was
pr_info("L2C: no controller entry found in the dtb\n");
>
> + else if (ret)
>   pr_err("L2C: failed to init: %d\n", ret);
>   }
>