Re: [PATCH 42/53] perf record: Prevent reading invalid data in record__mmap_read

From: Arnaldo Carvalho de Melo
Date: Mon Jan 11 2016 - 10:01:57 EST


Em Mon, Jan 11, 2016 at 01:00:07PM -0200, Arnaldo Carvalho de Melo escreveu:
> Em Mon, Jan 11, 2016 at 05:21:44PM +0300, Sergei Shtylyov escreveu:
> > On 01/11/2016 04:48 PM, Wang Nan wrote:
> > > size = head - old;
> > >+ if (size > (unsigned long)(md->mask) + 1) {
> > >+ WARN_ONCE(1, "WARNING: failed to keep up with mmap data. (warn only once)\n");
> >
> > WARNING is already printed by WARN*(), no?
>
> No, at least not in tools/include/asm/bug.h, perhaps include/asm/bug.h
> has this now and tools/ drifted? Checking now...

Indeed, need to bring it closer together again...

- Arnaldo