Re: [PATCH] thinkpad_acpi: Add support for keyboard backlight

From: Henrique de Moraes Holschuh
Date: Sat Jan 09 2016 - 12:36:22 EST


On Wed, Jan 6, 2016, at 06:45, Pali Rohár wrote:
> On Wednesday 30 December 2015 23:28:48 Pali Rohár wrote:
> > On Monday 28 December 2015 15:48:14 Pali Rohár wrote:
> > > > Also, is it working properly across suspend+resume?
> > >
> > > When doing resume from suspend or hibernate BIOS turning keyboard
> > > backlight automatically off.
> >
> > Fixed in v2.
> >
>
> Now I see that BIOS try to be too intelligent and automatically turn of
> keyboard backlight when LID is closed. When LID is open again then
> keyboard backlight stay turned off. Sysfs show correct state (brightness
> is zero).
>
> Should thinkpad acpi driver do something? Or let BIOS do that job?

Either is fine, as long as you ensure the driver knows the BIOS turned
off the backlight, which you did.

So, really, I don't mind if we follow the BIOS.

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh