Re: [RFC 11/13] x86/mm: Build arch/x86/mm/tlb.c even on !SMP

From: Dave Hansen
Date: Fri Jan 08 2016 - 18:55:58 EST


On 01/08/2016 03:15 PM, Andy Lutomirski wrote:
> @@ -352,3 +354,5 @@ static int __init create_tlb_single_page_flush_ceiling(void)
> return 0;
> }
> late_initcall(create_tlb_single_page_flush_ceiling);
> +
> +#endif /* CONFIG_SMP */

Heh, I was about to complain that you #ifdef'd out my lovely INVLPG
tunable. But I guess on UP you just get flush_tlb_mm_range() from:

> static inline void flush_tlb_mm_range(struct mm_struct *mm,
> unsigned long start, unsigned long end, unsigned long vmflag)
> {
> if (mm == current->active_mm)
> __flush_tlb_up();
> }

which doesn't even do INVLPG. How sad. Poor UP.