[PATCH v4.4-rc8 v4] dmaengine: ioatdma: Squelch framesize warnings

From: tim . gardner
Date: Fri Jan 08 2016 - 16:49:16 EST


From: Tim Gardner <tim.gardner@xxxxxxxxxxxxx>

CC [M] drivers/dma/ioat/prep.o
drivers/dma/ioat/prep.c: In function 'ioat_prep_pqxor':
drivers/dma/ioat/prep.c:682:1: warning: the frame size of 1048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}
^
drivers/dma/ioat/prep.c: In function 'ioat_prep_pqxor_val':
drivers/dma/ioat/prep.c:714:1: warning: the frame size of 1048 bytes is larger than 1024 bytes [-Wframe-larger-than=]
}

gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1)

Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
Cc: Dave Jiang <dave.jiang@xxxxxxxxx>
Cc: Prarit Bhargava <prarit@xxxxxxxxxx>
Cc: Nicholas Mc Guire <der.herr@xxxxxxx>
Cc: Jarkko Nikula <jarkko.nikula@xxxxxxxxxxxxxxx>
Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx>
---

v2 - use per CPU static buffers instead of dynamically allocating memory.
v3 - Use get_cpu_var/put_cpu_var which implicitly control preeemption. Drop
the wrapper function that no longer serves any purpose.
v4 - According to discussion between Dan Williams and Dave Jiang, MAX_SCF really
only needs to be 256. That is certainly a simpler patch then previous efforts.

Quoting from an email regarding v3:

Dan said, "Looks good to me... but now that I think about it, why is MAX_SCF set
to 1024 in the first place? Certainly it can't be bigger than the
maximum number of sources in a single operation which is 8 to 16.
Even md raid can only support up to 256 devices in an array. So I
think that contstant is bogus.
If we set it to 16 we may not even need the percpu change.
Dave?"

Dave responded, "You are right. It was an arbitrary number I threw in there to address
sparse warning. It can be reduced. 256 seems reasonable. "

drivers/dma/ioat/prep.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/ioat/prep.c b/drivers/dma/ioat/prep.c
index 6bb4a13..243421a 100644
--- a/drivers/dma/ioat/prep.c
+++ b/drivers/dma/ioat/prep.c
@@ -26,7 +26,7 @@
#include "hw.h"
#include "dma.h"

-#define MAX_SCF 1024
+#define MAX_SCF 256

/* provide a lookup table for setting the source address in the base or
* extended descriptor of an xor or pq descriptor
--
2.6.4