Re: arch/x86/xen/suspend.c:70:9: error: implicit declaration of function 'xen_pv_domain'

[Boris Ostrovsky]

On 12/22/2015 06:49 AM, Stefano Stabellini wrote:
> On Mon, 21 Dec 2015, Andrew Morton wrote:
> > On Mon, 21 Dec 2015 00:43:17 +0800 kbuild test robot <fengguang.wu@xxxxxxxxx> wrote:
> >
> > > First bad commit (maybe != root cause):
> > >
> > > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > > head:   69c37a92ddbf79d9672230f21a04580d7ac2f4c3
> > > commit: 71458cfc782eafe4b27656e078d379a34e472adf kernel: add support for gcc 5
> > > date:   1 year, 2 months ago
> > > config: x86_64-randconfig-x006-201551 (attached as .config)
> > > reproduce:
> > >          git checkout 71458cfc782eafe4b27656e078d379a34e472adf
> > >          # save the attached .config to linux build tree
> > >          make ARCH=x86_64
> > >
> > > All errors (new ones prefixed by >>):
> > >
> > >     arch/x86/xen/suspend.c: In function 'xen_arch_pre_suspend':
> > > > > arch/x86/xen/suspend.c:70:9: error: implicit declaration of function 'xen_pv_domain' [-Werror=implicit-function-declaration]
> > >          if (xen_pv_domain())
> > >              ^
> > hm, tricky!
> >
> > --- a/arch/x86/xen/suspend.c~arch-x86-xen-suspendc-include-xen-xenh
> > +++ a/arch/x86/xen/suspend.c
> > @@ -1,6 +1,7 @@
> >   #include <linux/types.h>
> >   #include <linux/tick.h>
> >   
> > +#include <xen/xen.h>
> >   #include <xen/interface/xen.h>
> >   #include <xen/grant_table.h>
> >   #include <xen/events.h>
>
> Looks like the right fix. David? Boris?

Why are we trying to compile this if CONFIG_XEN is not set?

-boris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/