Re: [PATCH] next: media: cx231xx: add #ifdef to fix compile error

[Okash Khawaja]

On Tue, Dec 22, 2015 at 09:46:19AM -0300, Javier Martinez Canillas wrote:
> Hello Okash,
> 
> On 12/22/2015 07:27 AM, Okash Khawaja wrote:
> > Compiling linux-next gave this warning:
> > 
> > drivers/media/usb/cx231xx/cx231xx-cards.c: In function
> > âcx231xx_usb_probeâ:
> > drivers/media/usb/cx231xx/cx231xx-cards.c:1754:36: error: âstruct
> > cx231xxâ has no member named âmedia_devâ
> >   retval = media_device_register(dev->media_dev);
> > 
> > Looking at the refactoring in past two commits, following seems like a
> > decent fix, i.e. to surround dev->media_dev by #ifdef
> > CONFIG_MEDIA_CONTROLLER.
> > 
> > Signed-off-by: Okash Khawaja <okash.khawaja@xxxxxxxxx>
> > ---
> >  drivers/media/usb/cx231xx/cx231xx-cards.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/media/usb/cx231xx/cx231xx-cards.c b/drivers/media/usb/cx231xx/cx231xx-cards.c
> > index 35692d1..220a5db 100644
> > --- a/drivers/media/usb/cx231xx/cx231xx-cards.c
> > +++ b/drivers/media/usb/cx231xx/cx231xx-cards.c
> > @@ -1751,7 +1751,9 @@ static int cx231xx_usb_probe(struct usb_interface *interface,
> >  	if (retval < 0)
> >  		goto done;
> >  
> > +#ifdef CONFIG_MEDIA_CONTROLLER
> >  	retval = media_device_register(dev->media_dev);
> > +#endif
> >  
> >  done:
> >  	if (retval < 0)
> >
> 
> Thanks for your patch, I've posted the same fix already:
> 
> https://lkml.org/lkml/2015/12/21/270
> 
> Best regards,
> -- 
> Javier Martinez Canillas
> Open Source Group
> Samsung Research America

Cool. There was another similar compile error

https://lkml.org/lkml/2015/12/22/196

Thanks,
Okash
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/