Re: [PATCH V2 06/23] XEN / PCI: Remove the dependence on arch x86 when PCI_MMCONFIG=y

[Tomasz Nowicki]

On 21.12.2015 19:12, Stefano Stabellini wrote:
> On Wed, 16 Dec 2015, Tomasz Nowicki wrote:
> > In drivers/xen/pci.c, there are arch x86 dependent codes when
> > CONFIG_PCI_MMCONFIG is enabled, since CONFIG_PCI_MMCONFIG
> > depends on ACPI, so this will prevent XEN PCI running on other
> > architectures using ACPI with PCI_MMCONFIG enabled (such as ARM64).
> >
> > Fortunatly, it can be sloved in a simple way. In drivers/xen/pci.c,
> > the only x86 dependent code is if ((pci_probe & PCI_PROBE_MMCONF) == 0),
> > and it's defined in asm/pci_x86.h, the code means that
> > if the PCI resource is not probed in PCI_PROBE_MMCONF way, just
> > ingnore the xen mcfg init. Actually this is duplicate, because
> > if PCI resource is not probed in PCI_PROBE_MMCONF way, the
> > pci_mmconfig_list will be empty, and the if (list_empty())
> > after it will do the same job.
> >
> > So just remove the arch related code and the head file, this
> > will be no functional change for x86, and also makes xen/pci.c
> > usable for other architectures.
> >
> > Signed-off-by: Hanjun Guo <hanjun.guo@xxxxxxxxxx>
> > CC: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> > CC: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>
> > Cc: Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
> > Tested-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@xxxxxxx>
>
> Acked-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>

Thanks Stefano.

Tomasz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/