Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing

[Andi Kleen]

> > -			fprintf(out, "                                   ");
> > +			print_metric(ctxp, NULL, NULL, "insn per cycle", 0);
> >  		}
> >  		total = avg_stats(&runtime_stalled_cycles_front_stats[ctx][cpu]);
> >  		total = max(total, avg_stats(&runtime_stalled_cycles_back_stats[ctx][cpu]));
> >  
> > +		out->new_line(ctxp);
> >  		if (total && avg) {
> >  			ratio = total / avg;
> > -			fprintf(out, "\n");
> 
> you haven't address my first comment in here http://marc.info/?l=linux-kernel&m=144662610723134&w=2

The new_line is always needed because stalled cycles is always printed.

The reason it is always printed is that metric-only needs to see all the
metrics for its column headers. That's why there are else cases
everywhere.


-Andi
-- 
ak@xxxxxxxxxxxxxxx -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/