Re: [PATCH v3 1/5] Staging: dgnc: dgnc_neo.c: usleep_range is preferred over udelay

[Greg KH]

On Sat, Nov 14, 2015 at 08:10:42PM +0530, Nizam Haider wrote:
> Fix ceckpatch warning

spelling?

> 
> Signed-off-by: Nizam Haider <nijamh@xxxxxxx>
> ---
>  drivers/staging/dgnc/dgnc_neo.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 8106f52..cf5bfc7 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -1335,7 +1335,7 @@ static void neo_flush_uart_write(struct channel_t *ch)
>  		/* Check to see if the UART feels it completely flushed the FIFO. */
>  		tmp = readb(&ch->ch_neo_uart->isr_fcr);
>  		if (tmp & 4)
> -			udelay(10);
> +			usleep_range(10, 50);

Where did you get this range from?  Did you make it up?  Please don't.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/