Re: [PATCH] mm, oom: initiallize all new zap_details fields before use

From: Michal Hocko
Date: Mon Dec 21 2015 - 03:31:00 EST


On Fri 18-12-15 20:04:51, Sasha Levin wrote:
> Commit "mm, oom: introduce oom reaper" forgot to initialize the two new fields
> of struct zap_details in unmap_mapping_range(). This caused using stack garbage
> on the call to unmap_mapping_range_tree().
>
> Signed-off-by: Sasha Levin <sasha.levin@xxxxxxxxxx>

Thanks for catching that.
Acked-by: Michal Hocko <mhocko@xxxxxxxx>

> ---
> mm/memory.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/memory.c b/mm/memory.c
> index 206c8cd..0e32993 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -2431,6 +2431,7 @@ void unmap_mapping_range(struct address_space *mapping,
> details.last_index = hba + hlen - 1;
> if (details.last_index < details.first_index)
> details.last_index = ULONG_MAX;
> + details.check_swap_entries = details.ignore_dirty = false;
>
>
> /* DAX uses i_mmap_lock to serialise file truncate vs page fault */
> --
> 1.7.10.4
>

--
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/