Re: [PATCH v5] extcon: add Maxim MAX3355 driver

[Sergei Shtylyov]

Hello.

On 12/20/2015 05:31 PM, Chanwoo Choi wrote:

> This patch depend on GPIOLIB configuration as following:
> I modified it with following diff and applied it.
>
> diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
> index ba4db7d..3d89e60 100644
> --- a/drivers/extcon/Kconfig
> +++ b/drivers/extcon/Kconfig
> @@ -54,6 +54,7 @@ config EXTCON_MAX14577
>
>   config EXTCON_MAX3355
>          tristate "Maxim MAX3355 USB OTG EXTCON Support"
> +       depends on GPIOLIB || COMPILE_TEST

   If it won't compile w/o gpiolib, what's the use of COMIPLE_TEST?
   And no, it shouldn't depend on gpiolib. It has empty stubs for the case of 
CONFIG_GPIOLIB=n. Obviously something is wrong with the GPIO headers, I'll 
look into it.

[...]

> Thanks,
> Chanwoo Choi

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/