Re: [PATCH] iio: ina2xx: fix channel order in software buffer

From: Jonathan Cameron
Date: Sat Dec 19 2015 - 10:07:13 EST


On 15/12/15 15:26, Marc Titinger wrote:
> POWER and CURRENT were swapped out in the buffer:
> was current2 and power3, correct order is power2 and current3.
>
> Signed-off-by: Marc Titinger <mtitinger@xxxxxxxxxxxx>
>
> ---
>
> Hi Jon,
>
> we just found this while testing with the buffered mode.
> My apologies for missing this bug ealier.
>
> Cheers,
> Marc.
>
> ---
>
Applied this one to the togreg branch of iio.git which will get
initially pushed out as testing for the autobuilders to play with it.

> drivers/iio/adc/ina2xx-adc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index 98939ba..91e1f2b 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -427,8 +427,8 @@ static ssize_t ina2xx_shunt_resistor_store(struct device *dev,
> static const struct iio_chan_spec ina2xx_channels[] = {
> INA2XX_CHAN_VOLTAGE(0, INA2XX_SHUNT_VOLTAGE),
> INA2XX_CHAN_VOLTAGE(1, INA2XX_BUS_VOLTAGE),
> - INA2XX_CHAN(IIO_CURRENT, 2, INA2XX_CURRENT),
> - INA2XX_CHAN(IIO_POWER, 3, INA2XX_POWER),
> + INA2XX_CHAN(IIO_POWER, 2, INA2XX_POWER),
> + INA2XX_CHAN(IIO_CURRENT, 3, INA2XX_CURRENT),
> IIO_CHAN_SOFT_TIMESTAMP(4),
> };
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/