Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints

[Thomas Gleixner]

On Mon, 14 Dec 2015, Jeff Merkey wrote:
> +		/*
> +		* check if we got an execute breakpoint
> +		* from the dr7 register.  if we did, set
> +		* the resume flag to avoid int1 recursion.

Malformatted comment as any other comment you touched.

> +		*/
> +		if ((dr7 & (3 << ((i * 4) + 16))) == 0)
> +			args->regs->flags |= X86_EFLAGS_RF;

This still uses magic numbers instead of the proper defines. I asked
for that before.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/